[Linux-PowerEdge] Request: improve script quality

Sven Ulland sveniu at opera.com
Mon Aug 29 01:31:55 CDT 2016


This is due to the DUP scripts being written in bash, but the interpreter
(shebang on the first line) points to /bin/sh. On RHEL and related systems,
this is fine, because /bin/sh will invoke a shell with full bash
compatibility. On others, like those derived from Debian, /bin/sh will
invoke a shell with only bourne compatibility (not bourne *again*), or more
recently, a more POSIX sh-like shell like dash.

I would suggest to fix the DUP infrastructure to use the appropriate script
interpreter (i.e. setting it to /bin/bash), so that it works on platforms
other than RHEL/etc.

S.

On Fri, Aug 26, 2016 at 4:48 PM, <Santosh_Gore at dell.com> wrote:

> *Dell - Internal Use - Confidential *
>
> Hi
>
>
>
> Thanks for feedback.  We are able to install the same package successfully
> on the RHEL operating system. What is operating system installed on your
> system?
>
>
>
> [root at win-jbnopnei1jj Desktop]# ./Diagnostics_Application_298ND_LN64_2.0_A00.BIN
> -q -f
>
> Collecting inventory...
>
> ...............................................
>
> Running validation...
>
>
>
> OS COLLECTOR 2.0
>
>
>
> The version of this Update Package is the same as the currently installed
> version.
>
> Software application name: OS COLLECTOR 2.0
>
> Package version: 2.0
>
> Installed version: 2.0
>
>
>
>
>
> Executing update...
>
> WARNING: DO NOT STOP THIS PROCESS OR INSTALL OTHER DELL PRODUCTS WHILE
> UPDATE IS IN PROGRESS.
>
> THESE ACTIONS MAY CAUSE YOUR SYSTEM TO BECOME UNSTABLE!
>
> ............................................................
> ............................................................
> ...................
>
> The update completed successfully.
>
>
>
> Thanks
>
> Santosh
>
> -----Original Message-----
>
> From: linux-poweredge-bounces-Lists On Behalf Of
> lhecking at users.sourceforge.net
>
> Sent: Friday, August 26, 2016 6:39 PM
>
> To: linux-poweredge-Lists <linux-poweredge at lists.us.dell.com>
>
> Subject: [Linux-PowerEdge] Request: improve script quality
>
>
>
>
>
> For the Dell people here on this list: can you please engage with the
> relevant developers to improve the quailty of shell scripting in the update
> packages.
>
> Considering how many years these updates have been provided for, this is
> really poor coding.
>
>
>
> Fetching Diagnostics_Application_298ND_LN64_2.0_A00 ...
>
> Installing Diagnostics_Application_298ND_LN64_2.0_A00 ...
>
> /usr/libexec/dell_dup/Diagnostics_Application_298ND_LN64_2.0_A00.BIN:
> line 91: [: =: unary operator expected
>
> /usr/libexec/dell_dup/Diagnostics_Application_298ND_LN64_2.0_A00.BIN:
> line 82: [: =: unary operator expected
>
> /usr/libexec/dell_dup/Diagnostics_Application_298ND_LN64_2.0_A00.BIN:
> line 106: [: =: unary operator expected
>
> ./OSFlavourUtils.sh: line 22: [: =: unary operator expected
>
> ./OSFlavourUtils.sh: line 33: [: =: unary operator expected Collecting
> inventory...
>
> ./OSFlavourUtils.sh: line 42: [: =: unary operator expected
> ................................................
>
>
>
> Thank you.
>
>
>
> _______________________________________________
>
> Linux-PowerEdge mailing list
>
> Linux-PowerEdge at dell.com
>
> https://lists.us.dell.com/mailman/listinfo/linux-poweredge
>
> _______________________________________________
> Linux-PowerEdge mailing list
> Linux-PowerEdge at dell.com
> https://lists.us.dell.com/mailman/listinfo/linux-poweredge
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.us.dell.com/pipermail/linux-poweredge/attachments/20160829/003045cc/attachment-0001.html 


More information about the Linux-PowerEdge mailing list