LED control on M1730

[Michael_E_Brown at Dell.com]

Thanks! I have added this patch and it will be in the next release (2.0.2).
--
Michael

-----Original Message-----
From: libsmbios-devel-bounces at lists.us.dell.com on behalf of Jon Barnett
Sent: Mon 3/31/2008 9:29 AM
To: Brown, Michael E
Cc: libsmbios-devel at lists.us.dell.com
Subject: RE: LED control on M1730
 
Ok. Found the bug but C++ is not my forte really.

Patch is as follows:
diff -urN bin-unsupported.pristine/dellLEDCtl.cpp
bin-unsupported/dellLEDCtl.cpp
--- bin-unsupported.pristine/dellLEDCtl.cpp	2008-03-31
10:16:18.000000000 -0400
+++ bin-unsupported/dellLEDCtl.cpp	2008-03-31 10:18:04.000000000 -0400
@@ -278,7 +278,7 @@
 
         p2[0] = preserve ? 1 : 0;
     
-        p3[0] = u8(zone[4]);
+        p3[0] = u8(zone[3]);
 
         smi::doSimpleCallingInterfaceSmi(4, 6, args, res);
     }

Also attached as a file in case e-mail makes a hash of the in-line copy.
I've tested and it does control the panel LED.

Cheers,

JonB

On Sun, 2008-03-30 at 23:50 -0500, Michael_E_Brown at Dell.com wrote:

> Hmm. Might be a bug, or might be something that needs updating.
> 
> In general, I havent been able to do any maintenance on the led ctl stuff, as I am really tied up in a couple other projects at the moment.
> 
> If anybody has C++ programming skills and would like to try to debug it, I can go check to see if the docs changed. I previously sent the docs for this to the list last year at some point.
> 
> --
> Michael