[PATCH] firmware-tools 2.0.5 issues on EL4

[Michael E Brown]

On Sat, Feb 23, 2008 at 10:58:52AM +0200, Ville Skyttä wrote:
> On Tuesday 05 February 2008, Ville Skyttä wrote:
> > Hi,
> >
> > I've run into some issues with firmware-tools and firmware-addons-dell
> > (both version 2.0.5) on CentOS 4:
> >
> >
> > # bootstrap_firmware
> > No handlers could be found for logger "trace.firmwaretools"
> > Config Error: Plugin "firmware_addon_dell.extract_bios" cannot be found.
> >
> > First, 0001-Improve-plugin-import-error-message.patch improves the error
> > message when a plugin's import fails, this would have made it much easier
> > to find the actual problem.  After the patch, the above error message would
> > be:
> >
> >    Config Error: Plugin "firmware_addon_dell.extract_bios" cannot be
> > loaded: No module named subprocess
> 
> Looks like this patch hasn't been applied yet and I have received no 
> feedback - is there a problem with it?

Nope, just missed the original post. I've rejiggered my email rules to
make it harder for me to miss firmware-tools/libsmbios mail.

This patch looks good and will be applied.
--
Michael


> From fa12af4ec38b0454c2cea64966f2ae48da8bdc0b Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?Ville=20Skytt=C3=A4?= <ville.skytta at iki.fi>
> Date: Tue, 5 Feb 2008 20:38:30 +0200
> Subject: [PATCH] Improve plugin import error message.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=utf-8
> Content-Transfer-Encoding: 8bit
> 
> 
> Signed-off-by: Ville Skyttä <ville.skytta at iki.fi>
> ---
>  firmwaretools/plugins.py |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/firmwaretools/plugins.py b/firmwaretools/plugins.py
> index 5a9d33f..df9a344 100644
> --- a/firmwaretools/plugins.py
> +++ b/firmwaretools/plugins.py
> @@ -118,10 +118,10 @@ class Plugins:
>          except DisablePlugin:
>              moduleLogVerbose.info("\tPlugin raised DisablePlugin exception. skipping.")
>              return
> -        except ImportError:
> +        except ImportError, e:
>              sys.path = savePath
>              raise errors.ConfigError(
> -                'Plugin "%s" cannot be found.' % conf.module)
> +                'Plugin "%s" cannot be loaded: %s' % (conf.module, e))
>  
>          for i in conf.module.split(".")[1:]:
>              module = getattr(module, i)
> -- 
> 1.5.3.8
> 

> _______________________________________________
> firmware-tools-devel mailing list
> firmware-tools-devel at lists.us.dell.com
> http://lists.us.dell.com/mailman/listinfo/firmware-tools-devel