[PATCH] firmware-tools 2.0.5 issues on EL4

[Ville Skyttä]

Hi,

I've run into some issues with firmware-tools and firmware-addons-dell (both 
version 2.0.5) on CentOS 4:


# bootstrap_firmware
No handlers could be found for logger "trace.firmwaretools"
Config Error: Plugin "firmware_addon_dell.extract_bios" cannot be found.

First, 0001-Improve-plugin-import-error-message.patch improves the error 
message when a plugin's import fails, this would have made it much easier to 
find the actual problem.  After the patch, the above error message would be:

   Config Error: Plugin "firmware_addon_dell.extract_bios" cannot be loaded:
   No module named subprocess

Nitpick: this isn't IMHO really a "Config Error", so the message is still 
somewhat misleading.

Second, 0001-Remove-stray-subprocess-import.patch fixes the actual problem - 
it seems to me that "subprocess" is not needed in extract_bios.py at all, so 
no need to use the compat thing either.


Is the 'No handlers could be found for logger "trace.firmwaretools"' message 
printed on the console intentionally?  I'd rather not see it :)


While looking into this, I found that enabling/disabling plugins is not very 
intuitive.  "enabled=0" in a plugin config snippet does _not_ disable the 
plugin because the value "0" gets treated as a string, and the "0" string 
evaluates to *true* in Plugins.__init__'s "conf.enabled" check.  Using an 
empty value ("enabled=") in the config file disables it.  I'd 
expect "enabled=0" to do that, ditto preferably also "enabled=(false|no|)" 
(case insensitive).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Improve-plugin-import-error-message.patch
Type: text/x-diff
Size: 1162 bytes
Desc: not available
Url : http://lists.us.dell.com/pipermail/firmware-tools-devel/attachments/20080205/2b106009/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-stray-subprocess-import.patch
Type: text/x-diff
Size: 852 bytes
Desc: not available
Url : http://lists.us.dell.com/pipermail/firmware-tools-devel/attachments/20080205/2b106009/attachment-0001.bin