[PATCH]Debian files

[Michael E Brown]

On Thu, May 17, 2007 at 07:20:49PM +0530, Sadhana_B at dell.com wrote:
> I've attached the patch for firmware-addon-dell and I've pushed the
> changes in both the firmware-tools and firmware-addon-dell debian files
> in to staging. 

Some review comments:

First, always push to master unless directed otherwise. You created a
branch called 'new' and it took me a while before I found that. You are
completely free to do branches on your local tree. I do this myself a
lot. But when you push, unless directed otherwise (eg. committing a
bugfix to a stable tree), please push to master.

Next, introduce yourself to git, please.
http://www.kernel.org/pub/software/scm/git/docs/user-manual.html#telling-git-your-name
Your patch: 

    commit 465f69658b006bb9acc9f5ec85e5f7753596cc8e
    Author: root <root at sadh-ubuntu.(none)>
    Date:   Thu May 17 17:46:48 2007 +0530

My patches:

    commit e9b53c7fdab888788cd2d385550fd9cb6c01cf2b
    Author: Michael E Brown <michael_e_brown at dell.com>
    Date:   Wed May 16 10:12:32 2007 -0500

Next, commmit comments. We will probably need to start using a bug
tracking system (bts) soon. If we do, we'll mention bts numbers in git
commits. But for now, please give a short description of your patch in
the commit comment:

        modified:   pkg/debian/changelog
        modified:   pkg/debian/control
        modified:   pkg/debian/copyright
        deleted:    pkg/debian/firmware-tools.postinst
        deleted:    pkg/debian/firmware-tools.prerm
        build/
        firmware-tools-1.2.6.tar.gz

is not a good commit comment. Something along the lines of:
    Modified debian packaging files per review comments from Martin Pitt
    from Ubuntu.

that would be a sufficient commit comment.


About the patch:
1) change the email address in 'changelog' to your email since you will
be doing the releases.

2) small change to the copyright file:

-Upstream source is dual licensed GPL/OSL.
+Upstream license:
+This program is placed under the Open Software License (OSL) version 3.0 or later.
+ See http://www.opensource.org/licenses/osl-3.0.php for license text.
+
+Alternatively, you may license this program under the GNU General Public License, version 2.0 or later.
+
+  ... insert the rest of your addition here...


other than that, it looks good. Please make the above changes and
re-push to staging/.
--
Michael