dkms - module build reliability patch

Vladimir Simonov Vladimir.Simonov at acronis.com
Tue May 29 03:48:10 CDT 2007


Hello Matt,

We have been using dkms a couple years and have
experience with its work on width range of distributions.

We'd like to incorporate our patches into dkms mainstream.
For brief review and discussion I've summarized them into
single patch (dkms-final.patch). All others are its chunks.
The patches should be applied against dkms 2.0.16.1.

Brief description.

1. dkms-sbin-in-path - adds /sbin & /usr/sbin into PATH.
It fixes "dkms build ..." via sudo work. Without it
depmod can't be found. Checking for sbin in PATH is not
too reliable but enough in our opinion.

2. dkms-nomktemp.patch - some distributions do not
support "mktemp -d". Function mktempdir uses "mktemp -d"
if possible.

3. dkms-symlink_check - adds some harmless checks.
I don't remember the problem related to this patch
but it really existed :).

4. dkms-no-prepare-on-suse - fixes build on SuSE 9.1.
Really, the removed code looks very artificial fo me.

5. dkms-config-priority-to21 - the most complex and probably
the most questionable patch. It introduces:
5.1 Support for 2.6.21 kernel - the kernel depricates
prepare-all make option.
5.2 The following logic for kernel config file detection:
a) Never guess config file name if it is specified
in command line option.

If no config file name specified then
b) If .config file exists then use it witout any further
guessing.
c) If /proc/config.gz is found - use it (and unpack it if
necessary).
d) If /boot/config-KERNEL_VERSION exists - use it.


Will be glad to hear your opinion about the patches.
Best regards
Vladimir Simonov

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dkms-final.patch
Url: http://lists.us.dell.com/pipermail/dkms-devel/attachments/20070529/acd0f70c/attachment.bat 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dkms-sbin-in-path.patch
Url: http://lists.us.dell.com/pipermail/dkms-devel/attachments/20070529/acd0f70c/attachment-0001.bat 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dkms-nomktemp.patch
Url: http://lists.us.dell.com/pipermail/dkms-devel/attachments/20070529/acd0f70c/attachment-0002.bat 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dkms-symlink_check.patch
Url: http://lists.us.dell.com/pipermail/dkms-devel/attachments/20070529/acd0f70c/attachment-0003.bat 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dkms-no-prepare-on-suse.patch
Url: http://lists.us.dell.com/pipermail/dkms-devel/attachments/20070529/acd0f70c/attachment-0004.bat 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dkms-config-priority-to21.patch
Url: http://lists.us.dell.com/pipermail/dkms-devel/attachments/20070529/acd0f70c/attachment-0005.bat 


More information about the DKMS-devel mailing list