[PATCH] fix version comparison

[Matt Domsch]

On Fri, Apr 14, 2006 at 12:04:27PM -0500, Matt Domsch wrote:
> Two things have bothered me for a while.
> 1) DKMS was *requiring* that modules have modinfo lines like:
> 
> version: 38.0 abcdef0123456
> 
> which correspond to both the version and srcversion fields.  If the
> srcversion field isn't present (as it isn't on RHEL4 < U3), then it
> wouldn't bother doing any comparison on the version field.  Presumably
> this was because the value in the version field couldn't be trusted
> completely (which is kind of strange).

A quick browse of the i386 RHEL4 kernel modules show that there's only
1 module with an oddball version string, that's the 3c59x network driver:

version:        LK1.1.19 DBFD1C112761D573276AC45


There are a few with an epoch:version type of string:

version:        4:0.1.11-1 DB263EBC636F076D8ED5146

but in both these cases, the version comparison does the right thing.
So I'm going to discount the invalid version field concern and fix any
problems that causes (if any) as they're found.

Thanks,
Matt

-- 
Matt Domsch
Software Architect
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com