[Crowbar] dangerously misleading button text in Node Dashboard

Adam Spiers aspiers at suse.com
Mon Jul 16 08:43:37 CDT 2012


Rob Hirschfeld (Rob_Hirschfeld at Dell.com) wrote:
> Adam,
> 
> This is exactly why I like to put all that stuff in localizations!  Good suggestions.
> 
> Greg's right -you should not give the whole path in the t, just "t('.hw_update_tooltip') etc so that it uses the relative path.  If you give the whole path then the code is more fragile during refactoring.

Ah, nice!  I didn't know you could do that.

> Could you fix the paths

Done:

    https://github.com/SUSE-Cloud/barclamp-crowbar/commit/ff1c5a758626a72ae29486dd965771b7f4c83cf2

> and then resubmit?

I didn't submit a pull request yet, but when I do, it will be a single
commit generated by squashing the above commit into its parent.

Thanks!



More information about the Crowbar mailing list