[Crowbar] dangerously misleading button text in Node Dashboard

Rob_Hirschfeld at Dell.com Rob_Hirschfeld at Dell.com
Mon Jul 16 08:29:58 CDT 2012


Adam,

This is exactly why I like to put all that stuff in localizations!  Good suggestions.

Greg's right -you should not give the whole path in the t, just "t('.hw_update_tooltip') etc so that it uses the relative path.  If you give the whole path then the code is more fragile during refactoring.

Could you fix the paths and then resubmit?

Rob

-----Original Message-----
From: crowbar-bounces On Behalf Of Althaus, Gregory
Sent: Monday, July 16, 2012 8:03 AM
To: aspiers at suse.com; crowbar
Subject: Re: [Crowbar] dangerously misleading button text in Node Dashboard

I like it.  Thanks!  Rob may have some comments about the paths to in the t() function, but otherwise good.

Thanks,
Greg

-----Original Message-----
From: crowbar-bounces On Behalf Of Adam Spiers
Sent: Monday, July 16, 2012 7:57 AM
To: crowbar
Subject: Re: [Crowbar] dangerously misleading button text in Node Dashboard

Adam Spiers (aspiers at suse.com) wrote:
> We had a case internally where a VM in a production cloud was lost 
> because someone interpreted the 'Reset' button to mean just 'reboot', 
> rather than 'deallocate the node by ditching its config, then reboot'.
> I think this is a dangerously easy mistake to make, and I am working 
> on a patch to relabel the button to 'Deallocate' and make the 
> confirmation text more explicit about the consequent action.
> Similarly, I'm relabelling the 'Delete' button to 'Forget', to clarify 
> that only the node's records are deleted, not the node itself - if my 
> understanding is correct, this button will cause rediscovery but not a 
> rebuild.
> 
> So if a future pull request containing these changes is unlikely to be 
> welcomed, please let me know now ;-)

Here's the patch:

    https://github.com/SUSE-Cloud/barclamp-crowbar/commit/8107efc836ebb0832372442d88cd135e75ca3157

It also adds tooltips so that users can get a feel for what each button does without having to nervously press it or read the manual :-)

If nobody spots anything wrong with it in the next few days, I'll submit a pull request.

_______________________________________________
Crowbar mailing list
Crowbar at dell.com
https://lists.us.dell.com/mailman/listinfo/crowbar
For more information: https://github.com/dellcloudedge/crowbar/wiki

_______________________________________________
Crowbar mailing list
Crowbar at dell.com
https://lists.us.dell.com/mailman/listinfo/crowbar
For more information: https://github.com/dellcloudedge/crowbar/wiki



More information about the Crowbar mailing list